From 053a64063161c65a38c7c4739197d7ad8d3d9c99 Mon Sep 17 00:00:00 2001 From: Tom Hicks Date: Thu, 1 Jul 2021 02:21:41 -0700 Subject: [PATCH] Makes radio buttons suck less. Styles the advantage picker and proficiency picker. Makes the saving throws screen nicer. --- app/src/main/res/color/radio_button_text.xml | 5 + .../res/drawable/radio_button_checked.xml | 6 + .../res/drawable/radio_button_selector.xml | 5 + .../res/drawable/radio_button_unchecked.xml | 6 + .../res/layout/component_advantage_picker.xml | 40 +++- .../layout/component_advantage_picker2.xml | 78 +++++++ .../layout/component_proficiency_picker.xml | 40 +++- .../layout/fragment_edit_saving_throws.xml | 196 ++++++++++++------ app/src/main/res/values/colors.xml | 17 +- app/src/main/res/values/dimens.xml | 8 +- 10 files changed, 315 insertions(+), 86 deletions(-) create mode 100644 app/src/main/res/color/radio_button_text.xml create mode 100644 app/src/main/res/drawable/radio_button_checked.xml create mode 100644 app/src/main/res/drawable/radio_button_selector.xml create mode 100644 app/src/main/res/drawable/radio_button_unchecked.xml create mode 100644 app/src/main/res/layout/component_advantage_picker2.xml diff --git a/app/src/main/res/color/radio_button_text.xml b/app/src/main/res/color/radio_button_text.xml new file mode 100644 index 0000000..2b573b3 --- /dev/null +++ b/app/src/main/res/color/radio_button_text.xml @@ -0,0 +1,5 @@ + + + + + diff --git a/app/src/main/res/drawable/radio_button_checked.xml b/app/src/main/res/drawable/radio_button_checked.xml new file mode 100644 index 0000000..d5548cd --- /dev/null +++ b/app/src/main/res/drawable/radio_button_checked.xml @@ -0,0 +1,6 @@ + + + + + diff --git a/app/src/main/res/drawable/radio_button_selector.xml b/app/src/main/res/drawable/radio_button_selector.xml new file mode 100644 index 0000000..b9e7998 --- /dev/null +++ b/app/src/main/res/drawable/radio_button_selector.xml @@ -0,0 +1,5 @@ + + + + + diff --git a/app/src/main/res/drawable/radio_button_unchecked.xml b/app/src/main/res/drawable/radio_button_unchecked.xml new file mode 100644 index 0000000..dd01b1b --- /dev/null +++ b/app/src/main/res/drawable/radio_button_unchecked.xml @@ -0,0 +1,6 @@ + + + + + diff --git a/app/src/main/res/layout/component_advantage_picker.xml b/app/src/main/res/layout/component_advantage_picker.xml index 55473c4..103a73a 100644 --- a/app/src/main/res/layout/component_advantage_picker.xml +++ b/app/src/main/res/layout/component_advantage_picker.xml @@ -6,16 +6,17 @@ android:layout_height="wrap_content" android:layout_margin="@dimen/text_margin" tools:context=".ui.components.AdvantagePicker"> - + app:layout_constraintTop_toTopOf="parent" /> + android:background="@drawable/radio_button_selector" + android:button="@android:color/transparent" + android:gravity="center" + android:padding="@dimen/padding_normal" + android:text="@string/label_advantage_none" + android:textAppearance="@android:style/TextAppearance.Material.Button" + android:textColor="@color/radio_button_text" + tools:checked="true" /> + android:background="@drawable/radio_button_selector" + android:button="@android:color/transparent" + android:gravity="center" + android:padding="@dimen/padding_normal" + android:text="@string/label_advantage_advantage" + android:textAppearance="@android:style/TextAppearance.Material.Button" + android:textColor="@color/radio_button_text" + tools:checked="false" /> + android:background="@drawable/radio_button_selector" + android:button="@android:color/transparent" + android:gravity="center" + android:padding="@dimen/padding_normal" + android:text="@string/label_advantage_disadvantage" + android:textAppearance="@android:style/TextAppearance.Material.Button" + android:textColor="@color/radio_button_text" + tools:checked="false" /> diff --git a/app/src/main/res/layout/component_advantage_picker2.xml b/app/src/main/res/layout/component_advantage_picker2.xml new file mode 100644 index 0000000..1715eaa --- /dev/null +++ b/app/src/main/res/layout/component_advantage_picker2.xml @@ -0,0 +1,78 @@ + + + + + + + + + + + + + + + diff --git a/app/src/main/res/layout/component_proficiency_picker.xml b/app/src/main/res/layout/component_proficiency_picker.xml index 390b27e..608f569 100644 --- a/app/src/main/res/layout/component_proficiency_picker.xml +++ b/app/src/main/res/layout/component_proficiency_picker.xml @@ -6,16 +6,17 @@ android:layout_height="wrap_content" android:layout_margin="@dimen/text_margin" tools:context=".ui.components.ProficiencyPicker"> - + app:layout_constraintTop_toTopOf="parent" /> + android:background="@drawable/radio_button_selector" + android:button="@android:color/transparent" + android:gravity="center" + android:padding="@dimen/padding_normal" + android:text="@string/label_proficiency_none" + android:textAppearance="@android:style/TextAppearance.Material.Button" + android:textColor="@color/radio_button_text" + tools:checked="true" /> + android:background="@drawable/radio_button_selector" + android:button="@android:color/transparent" + android:gravity="center" + android:padding="@dimen/padding_normal" + android:text="@string/label_proficiency_proficient" + android:textAppearance="@android:style/TextAppearance.Material.Button" + android:textColor="@color/radio_button_text" + tools:checked="false" /> + android:background="@drawable/radio_button_selector" + android:button="@android:color/transparent" + android:gravity="center" + android:padding="@dimen/padding_normal" + android:text="@string/label_proficiency_expertise" + android:textAppearance="@android:style/TextAppearance.Material.Button" + android:textColor="@color/radio_button_text" + tools:checked="false" /> diff --git a/app/src/main/res/layout/fragment_edit_saving_throws.xml b/app/src/main/res/layout/fragment_edit_saving_throws.xml index 61b2c03..7d9df22 100644 --- a/app/src/main/res/layout/fragment_edit_saving_throws.xml +++ b/app/src/main/res/layout/fragment_edit_saving_throws.xml @@ -3,109 +3,169 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="match_parent" + tools:context=".ui.editmonster.EditSavingThrowsFragment"> + android:divider="?android:attr/dividerVertical" + android:orientation="vertical" + android:showDividers="middle"> - + android:layout_marginTop="@dimen/padding_large" + android:layout_marginBottom="@dimen/padding_normal" + android:orientation="vertical"> - + - + - + + + + android:layout_marginTop="@dimen/padding_large" + android:layout_marginBottom="@dimen/padding_normal" + android:orientation="vertical"> - + - + - + + + + + android:layout_marginTop="@dimen/padding_large" + android:layout_marginBottom="@dimen/padding_normal" + android:orientation="vertical"> - + - + - + + + + + android:layout_marginTop="@dimen/padding_large" + android:layout_marginBottom="@dimen/padding_normal" + android:orientation="vertical"> - + - + - + + + + + android:layout_marginTop="@dimen/padding_large" + android:layout_marginBottom="@dimen/padding_normal" + android:orientation="vertical"> - + - + - + + + + + android:layout_marginTop="@dimen/padding_large" + android:layout_marginBottom="@dimen/padding_normal" + android:orientation="vertical"> - + - + + + - \ No newline at end of file + diff --git a/app/src/main/res/values/colors.xml b/app/src/main/res/values/colors.xml index ba0ed7c..196b818 100644 --- a/app/src/main/res/values/colors.xml +++ b/app/src/main/res/values/colors.xml @@ -1,8 +1,17 @@ - #9B2818 - #661A10 - + + #9b2818 + #d25941 + #660000 + #ea7e00 + #ffae41 + #b15000 + #ffffff + #000000 + #ffffff + #000000 + #995500 @@ -14,4 +23,4 @@ #007AFF #5855D6 #FF2D55 - \ No newline at end of file + diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml index c6c3b92..681f490 100644 --- a/app/src/main/res/values/dimens.xml +++ b/app/src/main/res/values/dimens.xml @@ -3,5 +3,9 @@ 16dp 16dp 20sp - - \ No newline at end of file + 4dp + 4dp + 8dp + 16dp + 32dp +