Removes unused code from edit skills.

This commit is contained in:
2021-06-20 12:40:06 -07:00
parent d8baac26bf
commit 1449893e4e
3 changed files with 8 additions and 14 deletions

View File

@@ -67,7 +67,7 @@ public class EditSkillsFragment extends MCFragment {
} else { } else {
Logger.logError("Can't navigate to EditSkill with a null skill"); Logger.logError("Can't navigate to EditSkill with a null skill");
} }
}, null); });
recyclerView.setAdapter(adapter); recyclerView.setAdapter(adapter);
}); });

View File

@@ -9,6 +9,8 @@ import androidx.recyclerview.widget.RecyclerView;
import com.majinnaibu.monstercards.databinding.FragmentEditSkillsListItemBinding; import com.majinnaibu.monstercards.databinding.FragmentEditSkillsListItemBinding;
import com.majinnaibu.monstercards.models.Skill; import com.majinnaibu.monstercards.models.Skill;
import org.jetbrains.annotations.NotNull;
import java.util.List; import java.util.List;
/** /**
@@ -16,17 +18,16 @@ import java.util.List;
*/ */
public class EditSkillsRecyclerViewAdapter extends RecyclerView.Adapter<EditSkillsRecyclerViewAdapter.ViewHolder> { public class EditSkillsRecyclerViewAdapter extends RecyclerView.Adapter<EditSkillsRecyclerViewAdapter.ViewHolder> {
private final List<Skill> mValues; private final List<Skill> mValues;
private final ItemCallback mOnDelete;
private final ItemCallback mOnClick; private final ItemCallback mOnClick;
public EditSkillsRecyclerViewAdapter(List<Skill> items, ItemCallback onClick, ItemCallback onDelete) { public EditSkillsRecyclerViewAdapter(List<Skill> items, ItemCallback onClick) {
mValues = items; mValues = items;
mOnClick = onClick; mOnClick = onClick;
mOnDelete = onDelete;
} }
@NotNull
@Override @Override
public ViewHolder onCreateViewHolder(ViewGroup parent, int viewType) { public ViewHolder onCreateViewHolder(@NotNull ViewGroup parent, int viewType) {
return new ViewHolder(FragmentEditSkillsListItemBinding.inflate(LayoutInflater.from(parent.getContext()), parent, false)); return new ViewHolder(FragmentEditSkillsListItemBinding.inflate(LayoutInflater.from(parent.getContext()), parent, false));
} }
@@ -46,18 +47,11 @@ public class EditSkillsRecyclerViewAdapter extends RecyclerView.Adapter<EditSkil
return mValues.size(); return mValues.size();
} }
public void removeItem(int position) {
if (mOnDelete != null) {
Skill skill = mValues.get(position);
mOnDelete.onItemCallback(skill);
}
}
public interface ItemCallback { public interface ItemCallback {
void onItemCallback(Skill skill); void onItemCallback(Skill skill);
} }
public class ViewHolder extends RecyclerView.ViewHolder { public static class ViewHolder extends RecyclerView.ViewHolder {
public final TextView mContentView; public final TextView mContentView;
public Skill mItem; public Skill mItem;
@@ -66,6 +60,7 @@ public class EditSkillsRecyclerViewAdapter extends RecyclerView.Adapter<EditSkil
mContentView = binding.content; mContentView = binding.content;
} }
@NotNull
@Override @Override
public String toString() { public String toString() {
return super.toString() + " '" + mContentView.getText() + "'"; return super.toString() + " '" + mContentView.getText() + "'";

View File

@@ -17,7 +17,6 @@
app:layout_constraintEnd_toEndOf="parent" app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent" app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" app:layout_constraintTop_toTopOf="parent"
tools:context=".ui.editmonster.EditSkillsFragment"
tools:listitem="@layout/fragment_edit_skills_list_item" /> tools:listitem="@layout/fragment_edit_skills_list_item" />
<com.google.android.material.floatingactionbutton.FloatingActionButton <com.google.android.material.floatingactionbutton.FloatingActionButton