From 4e45a547f43c698093b3930911f4c22a682df453 Mon Sep 17 00:00:00 2001
From: Tom Hicks <headhunter3@gmail.com>
Date: Sun, 15 Aug 2021 14:16:44 -0700
Subject: [PATCH] Moves gradle dependency versions out of variables.

---
 Android/app/build.gradle | 38 +++++++++++++++++---------------------
 Android/build.gradle     |  4 +---
 2 files changed, 18 insertions(+), 24 deletions(-)

diff --git a/Android/app/build.gradle b/Android/app/build.gradle
index 1d8cad7..724ae07 100644
--- a/Android/app/build.gradle
+++ b/Android/app/build.gradle
@@ -11,13 +11,6 @@ if (propertiesFile.exists()) {
 def appCenterLocalSecret = properties.getProperty('appCenter.localSecret')
 def appCenterEnvSecret = System.getenv('APPCENTER_SECRET')
 def appCenterSecret = appCenterLocalSecret != null ? appCenterLocalSecret : appCenterEnvSecret != null ? appCenterEnvSecret : ""
-def appCenterSdkVersion = '3.3.0'
-def nav_version = '2.3.5'
-def room_version = '2.3.0'
-def rxjava_version = '3.0.0'
-def flipper_version = '0.87.0'
-def soloader_version = '0.10.1'
-def gson_version = '2.8.6'
 
 android {
     compileSdkVersion 30
@@ -63,6 +56,9 @@ android {
     buildFeatures {
         viewBinding true
     }
+    lintOptions {
+        checkDependencies true
+    }
 }
 
 dependencies {
@@ -73,8 +69,8 @@ dependencies {
     implementation 'androidx.appcompat:appcompat:1.3.1'
     implementation 'com.google.android.material:material:1.4.0'
     implementation 'androidx.constraintlayout:constraintlayout:2.1.0'
-    implementation "androidx.navigation:navigation-fragment:$nav_version"
-    implementation "androidx.navigation:navigation-ui:$nav_version"
+    implementation "androidx.navigation:navigation-fragment:2.3.5"
+    implementation "androidx.navigation:navigation-ui:2.3.5"
     implementation 'androidx.lifecycle:lifecycle-extensions:2.2.0'
     implementation 'androidx.legacy:legacy-support-v4:1.0.0'
     implementation 'androidx.recyclerview:recyclerview:1.2.1'
@@ -87,23 +83,23 @@ dependencies {
     androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
 
     // Room DB
-    implementation "io.reactivex.rxjava3:rxjava:$rxjava_version"
-    implementation "io.reactivex.rxjava3:rxandroid:$rxjava_version"
-    implementation "androidx.room:room-runtime:$room_version"
-    annotationProcessor "androidx.room:room-compiler:$room_version"
-    implementation "androidx.room:room-rxjava3:$room_version"
-    //testImplementation "androidx.room:room-testing:$room_version"
+    implementation "io.reactivex.rxjava3:rxjava:3.0.0"
+    implementation "io.reactivex.rxjava3:rxandroid:3.0.0"
+    implementation "androidx.room:room-runtime:2.3.0"
+    annotationProcessor "androidx.room:room-compiler:2.3.0"
+    implementation "androidx.room:room-rxjava3:2.3.0"
+    //testImplementation "androidx.room:room-testing:2.3.0"
 
     // AppCenter
-    debugImplementation "com.microsoft.appcenter:appcenter-analytics:${appCenterSdkVersion}"
-    debugImplementation "com.microsoft.appcenter:appcenter-crashes:${appCenterSdkVersion}"
+    debugImplementation "com.microsoft.appcenter:appcenter-analytics:3.3.3"
+    debugImplementation "com.microsoft.appcenter:appcenter-crashes:3.3.3"
 
     // Flipper
-    debugImplementation "com.facebook.flipper:flipper:$flipper_version"
-    debugImplementation "com.facebook.soloader:soloader:$soloader_version"
-    releaseImplementation "com.facebook.flipper:flipper-noop:$flipper_version"
+    debugImplementation "com.facebook.flipper:flipper:0.87.0"
+    debugImplementation "com.facebook.soloader:soloader:0.10.1"
+    releaseImplementation "com.facebook.flipper:flipper-noop:0.87.0"
 
     // Other 3rd Party
     implementation 'com.atlassian.commonmark:commonmark:0.15.2'
-    implementation "com.google.code.gson:gson:$gson_version"
+    implementation "com.google.code.gson:gson:2.8.6"
 }
diff --git a/Android/build.gradle b/Android/build.gradle
index b3530b4..d795424 100644
--- a/Android/build.gradle
+++ b/Android/build.gradle
@@ -6,9 +6,7 @@ buildscript {
     }
     dependencies {
         classpath 'com.android.tools.build:gradle:4.2.2'
-
-        def nav_version = "2.3.0"
-        classpath "androidx.navigation:navigation-safe-args-gradle-plugin:$nav_version"
+        classpath "androidx.navigation:navigation-safe-args-gradle-plugin:2.3.0"
 
         // NOTE: Do not place your application dependencies here; they belong
         // in the individual module build.gradle files