diff --git a/app/src/main/java/com/majinnaibu/monstercards/data/MonsterRepository.java b/app/src/main/java/com/majinnaibu/monstercards/data/MonsterRepository.java index c16a836..f639927 100644 --- a/app/src/main/java/com/majinnaibu/monstercards/data/MonsterRepository.java +++ b/app/src/main/java/com/majinnaibu/monstercards/data/MonsterRepository.java @@ -13,16 +13,16 @@ import io.reactivex.rxjava3.core.Completable; import io.reactivex.rxjava3.core.Flowable; import io.reactivex.rxjava3.schedulers.Schedulers; +@SuppressWarnings("ResultOfMethodCallIgnored") public class MonsterRepository { - private AppDatabase m_db; + private final AppDatabase m_db; public MonsterRepository(@NonNull AppDatabase db) { m_db = db; } public Flowable> getMonsters() { - return m_db.monsterDAO() .getAll() .subscribeOn(Schedulers.io()) diff --git a/app/src/main/java/com/majinnaibu/monstercards/helpers/CommonMarkHelper.java b/app/src/main/java/com/majinnaibu/monstercards/helpers/CommonMarkHelper.java index 91e6f9f..8e8c910 100644 --- a/app/src/main/java/com/majinnaibu/monstercards/helpers/CommonMarkHelper.java +++ b/app/src/main/java/com/majinnaibu/monstercards/helpers/CommonMarkHelper.java @@ -10,14 +10,6 @@ import org.commonmark.renderer.html.HtmlNodeRendererFactory; import org.commonmark.renderer.html.HtmlRenderer; public final class CommonMarkHelper { - private static final class MyNodeRendererFactory implements HtmlNodeRendererFactory { - - @Override - public NodeRenderer create(HtmlNodeRendererContext context) { - return null; - } - } - public static String toHtml(String rawCommonMark) { Parser parser = Parser.builder().build(); Node document = parser.parse(rawCommonMark); @@ -35,4 +27,12 @@ public final class CommonMarkHelper { HtmlRenderer renderer = HtmlRenderer.builder().build(); return renderer.render(document); } + + private static final class MyNodeRendererFactory implements HtmlNodeRendererFactory { + + @Override + public NodeRenderer create(HtmlNodeRendererContext context) { + return null; + } + } } diff --git a/app/src/main/java/com/majinnaibu/monstercards/models/Language.java b/app/src/main/java/com/majinnaibu/monstercards/models/Language.java index 1e72240..60e765c 100644 --- a/app/src/main/java/com/majinnaibu/monstercards/models/Language.java +++ b/app/src/main/java/com/majinnaibu/monstercards/models/Language.java @@ -7,13 +7,14 @@ import java.util.Objects; public class Language implements Comparator, Comparable { + private String mName; + private boolean mSpeaks; + public Language(String name, boolean speaks) { mName = name; mSpeaks = speaks; } - private String mName; - public String getName() { return mName; } @@ -22,8 +23,6 @@ public class Language implements Comparator, Comparable { mName = value; } - private boolean mSpeaks; - public boolean getSpeaks() { return mSpeaks; } diff --git a/app/src/main/java/com/majinnaibu/monstercards/models/SavingThrow.java b/app/src/main/java/com/majinnaibu/monstercards/models/SavingThrow.java index b9b33be..85a2798 100644 --- a/app/src/main/java/com/majinnaibu/monstercards/models/SavingThrow.java +++ b/app/src/main/java/com/majinnaibu/monstercards/models/SavingThrow.java @@ -4,13 +4,14 @@ import java.util.Comparator; public class SavingThrow implements Comparator, Comparable { + private String mName; + private int mOrder; + public SavingThrow(String name, int order) { mName = name; mOrder = order; } - private String mName; - public String getName() { return mName; } @@ -19,8 +20,6 @@ public class SavingThrow implements Comparator, Comparable { if (mOnClick != null) { @@ -70,7 +70,7 @@ public class EditLanguagesRecyclerViewAdapter extends RecyclerView.Adapter { - public interface ItemCallback { - void onItemCallback(Monster monster); - } - - private List mValues; private final Context mContext; private final ItemCallback mOnDelete; private final ItemCallback mOnClick; - private Disposable mDisposable; private final Flowable> mItemsObservable; private final View.OnClickListener mOnClickListener = new View.OnClickListener() { @Override @@ -40,6 +34,8 @@ public class MonsterListRecyclerViewAdapter extends RecyclerView.Adapter mValues; + private Disposable mDisposable; public MonsterListRecyclerViewAdapter(Context context, Flowable> itemsObservable, @@ -79,17 +75,6 @@ public class MonsterListRecyclerViewAdapter extends RecyclerView.Adapter mValues; private Disposable mSubscriptionHandler; + public SearchResultsRecyclerViewAdapter(MonsterRepository repository, ItemCallback onClick) { mRepository = repository; diff --git a/app/src/main/java/com/majinnaibu/monstercards/ui/shared/SwipeToDeleteCallback.java b/app/src/main/java/com/majinnaibu/monstercards/ui/shared/SwipeToDeleteCallback.java index 46830c2..d8bd51a 100644 --- a/app/src/main/java/com/majinnaibu/monstercards/ui/shared/SwipeToDeleteCallback.java +++ b/app/src/main/java/com/majinnaibu/monstercards/ui/shared/SwipeToDeleteCallback.java @@ -18,16 +18,11 @@ import com.majinnaibu.monstercards.R; public class SwipeToDeleteCallback extends ItemTouchHelper.SimpleCallback { - public interface OnDeleteCallback { - void onDelete(int position); - } - private final Drawable icon; private final ColorDrawable background; private final Paint clearPaint; private final OnDeleteCallback mOnDelete; private final Context mContext; - public SwipeToDeleteCallback(Context context, OnDeleteCallback onDelete) { super(0, ItemTouchHelper.LEFT); mOnDelete = onDelete; @@ -84,4 +79,8 @@ public class SwipeToDeleteCallback extends ItemTouchHelper.SimpleCallback { super.onChildDraw(c, recyclerView, viewHolder, dX, dY, actionState, isCurrentlyActive); } + + public interface OnDeleteCallback { + void onDelete(int position); + } } diff --git a/app/src/main/java/com/majinnaibu/monstercards/utils/Logger.java b/app/src/main/java/com/majinnaibu/monstercards/utils/Logger.java index de8ca12..622f141 100644 --- a/app/src/main/java/com/majinnaibu/monstercards/utils/Logger.java +++ b/app/src/main/java/com/majinnaibu/monstercards/utils/Logger.java @@ -4,7 +4,7 @@ import android.util.Log; public class Logger { public static final String LOG_TAG = "MonsterCards"; - + public static void logUnimplementedMethod() { Exception ex = new Exception(); StackTraceElement[] stackTrace = ex.getStackTrace(); diff --git a/app/src/main/res/layout/fragment_library.xml b/app/src/main/res/layout/fragment_library.xml index 7995387..09c3ba1 100644 --- a/app/src/main/res/layout/fragment_library.xml +++ b/app/src/main/res/layout/fragment_library.xml @@ -12,12 +12,12 @@ android:layout_width="match_parent" android:layout_height="match_parent" app:layoutManager="LinearLayoutManager" - tools:context=".MonsterListFragment" - tools:listitem="@layout/monster_list_content" - app:layout_constraintStart_toStartOf="parent" + app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toTopOf="parent" - app:layout_constraintBottom_toBottomOf="parent" /> + tools:context=".MonsterListFragment" + tools:listitem="@layout/monster_list_content" /> - \ No newline at end of file + app:layout_constraintEnd_toEndOf="parent" + app:srcCompat="@android:drawable/ic_input_add" + app:tint="@android:color/white" /> + diff --git a/app/src/main/res/layout/fragment_search.xml b/app/src/main/res/layout/fragment_search.xml index 3afd8c1..57c71f2 100644 --- a/app/src/main/res/layout/fragment_search.xml +++ b/app/src/main/res/layout/fragment_search.xml @@ -24,17 +24,17 @@ - \ No newline at end of file + diff --git a/app/src/main/res/menu/monster_detail_menu.xml b/app/src/main/res/menu/monster_detail_menu.xml index b4ad9ed..91a8230 100644 --- a/app/src/main/res/menu/monster_detail_menu.xml +++ b/app/src/main/res/menu/monster_detail_menu.xml @@ -1,10 +1,10 @@ - + - \ No newline at end of file +