From bf6220b339f7c463d00280c5845bef0ab15bc3a8 Mon Sep 17 00:00:00 2001 From: Tom Hicks Date: Mon, 5 Jul 2021 14:09:09 -0700 Subject: [PATCH] Makes dashboard views use dimension and string resources. --- .../main/res/layout/card_ability_score.xml | 14 ++-- app/src/main/res/layout/card_action.xml | 14 ++-- app/src/main/res/layout/card_armor_class.xml | 12 ++-- .../main/res/layout/card_challenge_rating.xml | 14 ++-- app/src/main/res/layout/card_hit_points.xml | 12 ++-- app/src/main/res/layout/card_initiative.xml | 12 ++-- app/src/main/res/layout/card_monster.xml | 64 +++++++++---------- .../main/res/layout/card_monster_short.xml | 46 ++++++------- .../main/res/layout/fragment_dashboard.xml | 2 + app/src/main/res/layout/tile_monster.xml | 32 +++++----- .../main/res/layout/tile_monster_short.xml | 26 ++++---- app/src/main/res/values/dimens.xml | 23 +++++-- app/src/main/res/values/strings.xml | 4 ++ 13 files changed, 146 insertions(+), 129 deletions(-) diff --git a/app/src/main/res/layout/card_ability_score.xml b/app/src/main/res/layout/card_ability_score.xml index b58646d..7dbba97 100644 --- a/app/src/main/res/layout/card_ability_score.xml +++ b/app/src/main/res/layout/card_ability_score.xml @@ -10,9 +10,9 @@ android:id="@+id/name" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_margin="2dp" + android:layout_margin="@dimen/text_icon_border_padding" android:textColor="@android:color/primary_text_light" - android:textSize="8sp" + android:textSize="@dimen/text_icon_tiny" android:textStyle="bold" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" @@ -23,9 +23,9 @@ android:id="@+id/advantage" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_margin="2dp" + android:layout_margin="@dimen/text_icon_border_padding" android:textColor="@android:color/primary_text_light" - android:textSize="8sp" + android:textSize="@dimen/text_icon_tiny" android:textStyle="bold" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toTopOf="parent" @@ -35,9 +35,9 @@ android:id="@+id/proficiency" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_margin="2dp" + android:layout_margin="@dimen/text_icon_border_padding" android:textColor="@android:color/primary_text_light" - android:textSize="8sp" + android:textSize="@dimen/text_icon_tiny" android:textStyle="bold" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintTop_toTopOf="parent" @@ -48,7 +48,7 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:textColor="@android:color/primary_text_light" - android:textSize="20sp" + android:textSize="@dimen/text_icon_size" android:textStyle="bold" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" diff --git a/app/src/main/res/layout/card_action.xml b/app/src/main/res/layout/card_action.xml index d17fcc5..2fe0f4b 100644 --- a/app/src/main/res/layout/card_action.xml +++ b/app/src/main/res/layout/card_action.xml @@ -3,17 +3,17 @@ xmlns:app="http://schemas.android.com/apk/res-auto" xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" - android:layout_height="match_parent" + android:layout_height="@dimen/action_card_height" android:background="@drawable/rectangle_background"> + app:layout_constraintStart_toStartOf="parent" /> @@ -45,7 +45,7 @@ android:id="@+id/boxesRow" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_margin="8dp" + android:layout_margin="@dimen/padding_normal" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toBottomOf="@id/meta"> @@ -53,8 +53,8 @@ + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> diff --git a/app/src/main/res/layout/card_monster_short.xml b/app/src/main/res/layout/card_monster_short.xml index 1e5b9a2..799f9aa 100644 --- a/app/src/main/res/layout/card_monster_short.xml +++ b/app/src/main/res/layout/card_monster_short.xml @@ -10,8 +10,8 @@ android:id="@+id/name" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_margin="8dp" - android:textSize="20sp" + android:layout_margin="@dimen/padding_normal" + android:textSize="@dimen/monster_card_name_text_size" android:textStyle="bold" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" @@ -22,8 +22,8 @@ android:id="@+id/meta" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_margin="8dp" - android:textSize="12sp" + android:layout_margin="@dimen/padding_normal" + android:textSize="@dimen/monster_card_meta_text_size" android:textStyle="italic" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" @@ -34,8 +34,8 @@ android:id="@+id/challengeRating" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_margin="8dp" - android:textSize="20sp" + android:layout_margin="@dimen/padding_normal" + android:textSize="@dimen/monster_card_name_text_size" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintTop_toTopOf="parent" tools:text="CR 1/8" /> @@ -44,7 +44,7 @@ android:id="@+id/boxesRow" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_margin="8dp" + android:layout_margin="@dimen/padding_normal" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" @@ -53,8 +53,8 @@ + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> diff --git a/app/src/main/res/layout/fragment_dashboard.xml b/app/src/main/res/layout/fragment_dashboard.xml index f44e54f..bb08ff8 100644 --- a/app/src/main/res/layout/fragment_dashboard.xml +++ b/app/src/main/res/layout/fragment_dashboard.xml @@ -10,8 +10,10 @@ android:id="@+id/list" android:layout_width="match_parent" android:layout_height="match_parent" + android:clipToPadding="false" android:divider="?android:attr/dividerVertical" android:dividerPadding="@dimen/text_margin" + android:padding="@dimen/padding_normal" app:layoutManager="LinearLayoutManager" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" diff --git a/app/src/main/res/layout/tile_monster.xml b/app/src/main/res/layout/tile_monster.xml index 60d9b15..068f945 100644 --- a/app/src/main/res/layout/tile_monster.xml +++ b/app/src/main/res/layout/tile_monster.xml @@ -10,10 +10,10 @@ android:id="@+id/name" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_margin="8dp" + android:layout_margin="@dimen/padding_normal" android:ellipsize="end" android:lines="1" - android:textSize="16sp" + android:textSize="@dimen/monster_tile_name_text_size" android:textStyle="bold" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" @@ -24,10 +24,10 @@ android:id="@+id/meta" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_margin="8dp" + android:layout_margin="@dimen/padding_normal" android:ellipsize="end" android:lines="1" - android:textSize="10sp" + android:textSize="@dimen/monster_tile_meta_text_size" android:textStyle="italic" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" @@ -38,7 +38,7 @@ android:id="@+id/boxesRow" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_margin="8dp" + android:layout_margin="@dimen/padding_normal" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toBottomOf="@id/meta"> @@ -46,8 +46,8 @@ + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> @@ -89,9 +89,9 @@ android:id="@+id/action" layout="@layout/card_action" android:layout_width="0dp" - android:layout_height="wrap_content" - android:layout_marginHorizontal="4dp" - android:layout_marginVertical="8dp" + android:layout_height="@dimen/action_card_height" + android:layout_marginHorizontal="@dimen/padding_small" + android:layout_marginVertical="@dimen/padding_normal" android:baselineAligned="false" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" diff --git a/app/src/main/res/layout/tile_monster_short.xml b/app/src/main/res/layout/tile_monster_short.xml index 5ec17ce..575cef8 100644 --- a/app/src/main/res/layout/tile_monster_short.xml +++ b/app/src/main/res/layout/tile_monster_short.xml @@ -10,10 +10,10 @@ android:id="@+id/name" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_margin="8dp" + android:layout_margin="@dimen/padding_normal" android:ellipsize="end" android:lines="1" - android:textSize="16sp" + android:textSize="@dimen/monster_tile_name_text_size" android:textStyle="bold" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" @@ -24,10 +24,10 @@ android:id="@+id/meta" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_margin="8dp" + android:layout_margin="@dimen/padding_normal" android:ellipsize="end" android:lines="1" - android:textSize="10sp" + android:textSize="@dimen/monster_tile_meta_text_size" android:textStyle="italic" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" @@ -38,7 +38,7 @@ android:id="@+id/boxesRow" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_margin="8dp" + android:layout_margin="@dimen/padding_normal" android:baselineAligned="false" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" @@ -48,8 +48,8 @@ + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> + android:layout_width="@dimen/icon_size" + android:layout_height="@dimen/icon_size" /> diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml index 681f490..ef75e89 100644 --- a/app/src/main/res/values/dimens.xml +++ b/app/src/main/res/values/dimens.xml @@ -1,11 +1,22 @@ - 16dp - 16dp - 20sp + 10sp + 80dp + 14sp 4dp - 4dp - 8dp - 16dp + 16dp + 40dp + 12sp + 20sp + 10sp + 16sp 32dp + 16dp + 8dp + 4dp + 20sp + 2dp + 16sp + 8sp + 16dp diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 87bf8cb..2922318 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -27,12 +27,14 @@ Alignment Armor Armor Class + AC Base Speed Basic Info Burrow Speed Can Hover Can Speak Challenge Rating + CR Charisma Climb Speed Condition Immunities @@ -55,7 +57,9 @@ Has a Shield Hit Dice Hit Points + HP + + INIT Intelligence Lair Actions Languages