maj/MonsterCards
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make AppCenter only included in debug builds.

Browse Source 
Moves Flipper initialization to the same place as AppCenter.
This commit is contained in:
Tom Hicks
2021-05-02 00:45:23 -07:00
committed by Tom Hicks
parent e8e19d5371
commit dc9066daca
8 changed files with 32 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
Android/app/src/debug/java/com/majinnaibu/monstercards/init/FlipperInitializer.java
View File

@@ -2,10 +2,6 @@ package com.majinnaibu.monstercards.init;
import android.content.Context;
import android.os.Bundle;
import androidx.navigation.NavController;
import androidx.navigation.NavDestination;
import com.facebook.flipper.android.AndroidFlipperClient;
import com.facebook.flipper.android.utils.FlipperUtils;
@@ -14,9 +10,7 @@ import com.facebook.flipper.plugins.databases.DatabasesFlipperPlugin;
import com.facebook.flipper.plugins.inspector.DescriptorMapping;
import com.facebook.flipper.plugins.inspector.InspectorFlipperPlugin;
import com.facebook.flipper.plugins.navigation.NavigationFlipperPlugin;
import com.facebook.flipper.plugins.sharedpreferences.SharedPreferencesFlipperPlugin;
import com.facebook.soloader.SoLoader;
import com.google.gson.Gson;
import com.majinnaibu.monstercards.BuildConfig;
public class FlipperInitializer {
@@ -28,15 +22,10 @@ public class FlipperInitializer {
final FlipperClient client = AndroidFlipperClient.getInstance(ctx);
client.addPlugin(new InspectorFlipperPlugin(ctx, DescriptorMapping.withDefaults()));
client.addPlugin(new DatabasesFlipperPlugin(ctx));
client.addPlugin(new SharedPreferencesFlipperPlugin(ctx));
client.addPlugin(NavigationFlipperPlugin.getInstance());
client.start();
}
}
public static void sendNavigationEvent(NavController controller, NavDestination destination, Bundle arguments) {
Gson gson = new Gson();
String json = gson.toJson(arguments != null ? arguments : new Bundle());
NavigationFlipperPlugin.getInstance().sendNavigationEvent(String.format("%s:%s", destination.getLabel(), json), null, null);
}
}

31
Android/app/src/debug/java/com/majinnaibu/monstercards/utils/FlipperInitializer.java
View File

@@ -1,31 +0,0 @@
package com.majinnaibu.monstercards.utils;
import android.content.Context;
import com.facebook.flipper.android.AndroidFlipperClient;
import com.facebook.flipper.android.utils.FlipperUtils;
import com.facebook.flipper.core.FlipperClient;
import com.facebook.flipper.plugins.databases.DatabasesFlipperPlugin;
import com.facebook.flipper.plugins.inspector.DescriptorMapping;
import com.facebook.flipper.plugins.inspector.InspectorFlipperPlugin;
import com.facebook.flipper.plugins.navigation.NavigationFlipperPlugin;
import com.facebook.soloader.SoLoader;
import com.majinnaibu.monstercards.BuildConfig;
public class FlipperInitializer {
public static void init(Context ctx) {
SoLoader.init(ctx, false);
if (BuildConfig.DEBUG && FlipperUtils.shouldEnableFlipper(ctx)) {
final FlipperClient client = AndroidFlipperClient.getInstance(ctx);
client.addPlugin(new InspectorFlipperPlugin(ctx, DescriptorMapping.withDefaults()));
client.addPlugin(new DatabasesFlipperPlugin(ctx));
client.addPlugin(NavigationFlipperPlugin.getInstance());
client.start();
}
}
}

13
Android/app/src/main/java/com/majinnaibu/monstercards/MainActivity.java
View File

@@ -9,9 +9,7 @@ import androidx.navigation.ui.AppBarConfiguration;
import androidx.navigation.ui.NavigationUI;
import com.google.android.material.bottomnavigation.BottomNavigationView;
import com.microsoft.appcenter.AppCenter;
import com.microsoft.appcenter.analytics.Analytics;
import com.microsoft.appcenter.crashes.Crashes;
import com.majinnaibu.monstercards.init.AppCenterInitializer;
public class MainActivity extends AppCompatActivity {
@@ -25,14 +23,7 @@ public class MainActivity extends AppCompatActivity {
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
if (BuildConfig.APPCENTER_SECRET != null && !"".equals(BuildConfig.APPCENTER_SECRET)) {
AppCenter.start(
getApplication(),
BuildConfig.APPCENTER_SECRET,
Analytics.class,
Crashes.class
);
}
AppCenterInitializer.init(getApplication());
setContentView(R.layout.activity_main);
BottomNavigationView navView = findViewById(R.id.nav_view);
// Passing each menu ID as a set of Ids because each

2
Android/app/src/main/java/com/majinnaibu/monstercards/MonsterCardsApplication.java
View File

@@ -10,7 +10,7 @@ import androidx.room.migration.Migration;
import androidx.sqlite.db.SupportSQLiteDatabase;
import com.majinnaibu.monstercards.data.MonsterRepository;
import com.majinnaibu.monstercards.utils.FlipperInitializer;
import com.majinnaibu.monstercards.init.FlipperInitializer;
public class MonsterCardsApplication extends Application {

12
Android/app/src/release/java/com/majinnaibu/monstercards/init/FlipperInitializer.java
View File

@@ -1,17 +1,9 @@
package com.majinnaibu.monstercards.init;
import android.content.Context;
import android.os.Bundle;
import androidx.navigation.NavController;
import androidx.navigation.NavDestination;
@SuppressWarnings("unused")
public class FlipperInitializer {
public static void init(Context ctx) {
}
public static void init(Context ctx) {}
public static void sendNavigationEvent(NavController controller, NavDestination destination, Bundle arguments) {
}
}
}

9
Android/app/src/release/java/com/majinnaibu/monstercards/utils/FlipperInitializer.java
View File

@@ -1,9 +0,0 @@
package com.majinnaibu.monstercards.utils;
import android.content.Context;
public class FlipperInitializer {
public static void init(Context ctx) {}
}