Cleans up NewCharacter.

This commit is contained in:
2023-03-02 00:47:18 -08:00
parent 70ce7cf911
commit 8dde2db07f
2 changed files with 13 additions and 26 deletions

View File

@@ -18,13 +18,6 @@
* Spending virtue points * Spending virtue points
# Low Priority # Low Priority
* Calculating values not directly queried for.
* Conviction
* Instinct
* Generation
* Willpower
* Humanity/RoadValue
* Change character initializer to use abilityGroups/abilities instead of individual setTalent, setSkill, setKnowledge
* Rename items, abilities/abilities, abilityGroups rename the shared arrays and constants too * Rename items, abilities/abilities, abilityGroups rename the shared arrays and constants too
* Change CharacterType to use fields like attribute_1_1 instead of attr_strength * Change CharacterType to use fields like attribute_1_1 instead of attr_strength
* Same for abilities like knowledge_computer -> ability_3_2, background_allies -> background_1, and discipline_obeah -> discipline_13. * Same for abilities like knowledge_computer -> ability_3_2, background_allies -> background_1, and discipline_obeah -> discipline_13.

View File

@@ -1115,32 +1115,26 @@ Sub NewCharacter (ch As CharacterType)
ch.willpower = 0 ch.willpower = 0
' Arrays/Objects ' Arrays/Objects
' Disciplines ' Abilities (Talents/Skills/Knowledges)
For index = 1 To DISCIPLINES_COUNT For groupIndex = 1 To ABILITY_GROUPS_COUNT
Call SetDiscipline(ch, index, 0) For index = 1 To GetNumItemsForAbilityGroup(groupIndex)
Next Call SetAbilityValue(ch, groupIndex, index, 0)
' Attributes
For GroupIndex = 1 To ATTRIBUTE_GROUPS_COUNT
For AttributeIndex = 1 To GetNumAttributesInGroup(GroupIndex)
Call SetAttributeValue(ch, GroupIndex, AttributeIndex, 1)
Next Next
Next Next
' Talents ' Attributes
For index = 1 To TALENTS_COUNT For groupIndex = 1 To ATTRIBUTE_GROUPS_COUNT
Call SetTalent(ch, index, 0) For index = 1 To GetNumAttributesInGroup(groupIndex)
Next Call SetAttributeValue(ch, groupIndex, index, 1)
' Skills Next
For index = 1 To SKILLS_COUNT
Call SetSkill(ch, index, 0)
Next
' Knowledges
For index = 1 To KNOWLEDGES_COUNT
Call SetKnowledge(ch, index, 0)
Next Next
' Backgrounds ' Backgrounds
For index = 1 To BACKGROUNDS_COUNT For index = 1 To BACKGROUNDS_COUNT
Call SetBackground(ch, index, 0) Call SetBackground(ch, index, 0)
Next Next
' Disciplines
For index = 1 To DISCIPLINES_COUNT
Call SetDiscipline(ch, index, 0)
Next
End Sub End Sub
Sub BuildMenu (items() As MenuItem, labels() As String, count As Integer) Sub BuildMenu (items() As MenuItem, labels() As String, count As Integer)